Transcoding to USB MP3 doesn't work

clementine-player / Clementine

:tangerine: Clementine Music Player

https://www.clementine-player.org/

GNU General Public License v3.0

3.72k stars 671 forks source link

Transcoding to USB MP3 doesn't work #6715

Open akovia opened 4 years ago

akovia commented 4 years ago

Before posting

Please follow the steps below and check the boxes with [x] once you did the step.

[x] I checked the issue tracker for similar issues
[x] I checked the changelog if the issue is already resolved
[x] I tried the latest Clementine build from here

System information

Please provide information about your system and the version of Clementine used.

Operating System: Arch Linux
Clementine version: 1.4 rc1

Expected behaviour / actual behaviour

Copying files to my usb drive should be converted to mp3 if they are not already

Files are never converted and are just copied over in their original format. You can see after initiating a copy, that in the Organize Files dialog, it shows the original formats in the preview window.

Steps to reproduce the problem (only for bugs)

Configure usb device to convert all music to mp3
Copy any media file to a usb drive that isn't mp3

Device Options Organize Files

jbroadus commented 4 years ago

For me, the transcoding is working, but the file extension isn't being set correctly.

file /run/media/jim/Lexar/William\ Onyeabor/Who\ Is\ William\ Onyeabor/02\ -\ Atomic\ Bomb.flac 
/run/media/jim/Lexar/William Onyeabor/Who Is William Onyeabor/02 - Atomic Bomb.flac: Audio file with ID3 version 2.4.0, contains:MPEG ADTS, layer III, v1, 48 kbps, 44.1 kHz, JntStereo

The tagreader then fails because the file doesn't look like a valid FLAC.

akovia commented 4 years ago

For me, the transcoding is working, but the file extension isn't being set correctly.
file /run/media/jim/Lexar/William\ Onyeabor/Who\ Is\ William\ Onyeabor/02\ -\ Atomic\ Bomb.flac 
/run/media/jim/Lexar/William Onyeabor/Who Is William Onyeabor/02 - Atomic Bomb.flac: Audio file with ID3 version 2.4.0, contains:MPEG ADTS, layer III, v1, 48 kbps, 44.1 kHz, JntStereo
The tagreader then fails because the file doesn't look like a valid FLAC.

Wow, I can't believe I missed that. I thought Thunar used file magic instead of the extension to determine mime type, but they indeed have been converted. Hopefully this will be an easy bug to squish.

jbroadus commented 4 years ago

Looks like an easy fix to correct the transcoding. Fixing the dialog display will require a bit more.

jbroadus commented 4 years ago

This should be fixed in the latest. There are still some ui issues around automatically transcoded files, but should be good for the common case.