cleoncheng2000 / pe

0 stars 0 forks source link

Sequence diagram bugs #12

Open cleoncheng2000 opened 1 year ago

cleoncheng2000 commented 1 year ago

image.png

image.png

Sequences diagram does not show any boxes for constructing the object/methods.

soc-pe-bot commented 1 year ago

Team's Response

As mentioned before, activation bars are optional.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Task Priority feature UML diagram has no activation bars

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


image.png

There should be activation bars for the Manager, UI, TaskList and Logic classes. But however they are all missing


[original: nus-cs2113-AY2223S2/pe-interim#1401] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is stated in the textbook that activation bars are optional, thus they were omitted in this diagram.

image.png

We believe that this is a cosmetic issue, which should be of VeryLow severity.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I agree with the VeryLow severity but this should not be outright rejected as some of the sequence diagrams in their DG had activation bars while some omitted them, making it rather inconsistent for the reader due to this cosmetic issue. As seen below: ![image.png](https://raw.githubusercontent.com/cleoncheng2000/pe/main/files/39adf3a6-4deb-4f00-b3b4-8f328951c978.png)
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]