search

cliffano / packer-post-processor-json-updater

Packer Post-Processor plugin for updating JSON files
BSD 3-Clause "New" or "Revised" License
10 stars 3 forks source link

Make `make build` work again #4

Closed xiaket closed 7 years ago

xiaket commented 7 years ago

With the new OSX upgrade(High Sierra), the old binary file failed to work, complaining:

2017/10/02 08:50:05 Starting plugin: /Users/xiaket/.xiaket/etc/bin/packer-post-processor-json-updater []string{"/Users/xiaket/.xiaket/etc/bin
/packer-post-processor-json-updater"}
2017/10/02 08:50:05 Waiting for RPC address for: /Users/xiaket/.xiaket/etc/bin/packer-post-processor-json-updater
2017/10/02 08:50:05 packer-post-processor-json-updater: failed MSpanList_Insert 0xb08000 0x87ea0e440fa 0x0 0x0
2017/10/02 08:50:05 packer-post-processor-json-updater: fatal error: MSpanList_Insert

I can confirm that my local binary file has the same checksum as the one provided in the release section.

In order to build the post processor again, I have to tweak some imports. I also did a make style to clean up some formatting, but that's all I have done. make build can produce the binary files in ther release section, I've also tested my local build(darwin/amd64) and it worked.

I would also suggest an update in Godeps dir is in order.

cliffano commented 7 years ago

Thanks @xiaket for the PR.