Closed brianjmurrell closed 4 months ago
ok, so I see some information saying that Submodules are indeed checked out at specific commits instead of branches.
https://www.git-tower.com/learn/git/faq/detached-head-when-checkout-commit
https://www.git-tower.com/learn/git/ebook/en/command-line/advanced-topics/submodules#start
So it looks like we need to use git status to get the HEAD detached at 3557a0e
I'm not sure if there are other changes required for the update itself.
Yeah, typically submodules are checked out at a specific commit. I believe newer versions of git however are supposed to be able to reference a branch and will update the submodule to the tip of that branch when git submodule update
is done.
In this case however, it's probably checkout out by commit hash and not being maintained by the super-module so I would prefer it just managed it's own "freshness". I suppose I could just ignore the submodule reference and check out my own independent copy and work from that. That said, it would probably be nice if this use-case worked for others in this situation also.
I'll see if I can set up some submodules and test this out. I have no doubt it can be supported, I just need to have a play as I have never used submodules before.
I'll try and create a new branch for this and #1677 and if it works I look to merge it all up
Obviously you would need to manually update to that version before auto-updating would become possible ;)
Can you have a play with submodule-1
branch?
this works at my side, but I note that when I created the submodule, I already had
# git rev-parse --verify --quiet '@{upstream}'
46b2e8998ce7c0e4b853272f0bdb06a558852c81
# ./nzbToMedia.py
...
[13:56:47] [INFO]::MAIN: Checking if source needs an update
[13:56:48] [ERROR]::MAIN: Unknown current version number, don't know if we should update or not
when is switched the submodule to submodule-1
branch
# git rev-parse --verify --quiet '@{upstream}'
12f31ce7e1d859d6460b868eb4bc7af87acc25d7
...
[13:57:23] [INFO]::MAIN: Checking if git needs an update
[13:57:24] [INFO]::MAIN: No update needed
[13:57:24] [INFO]::MAIN: nzbToMedia Version:12f31ce7e1d859d6460b868eb4bc7af87acc25d7 Branch:submodule-1 (Linux 4.14.x)
actually, I have just merged this up to nightly, and about to merge all the way up to master.
In all honesty, I'm just now noticing that the parent project that was submoduling this project stopped doing so a couple of years ago and expect people to just maintain their own copy of this project.
I will probably just do that as I suggested previously and maintain my own separate non-submodule copy.
But having this project understand submodules is probably still a good thing.
Describe the bug Reports:
in the log.
Technical Specs
Expected behavior Version checking should work
Log
This appears to be happening because:
FWIW: