Closed clockworkbits closed 6 years ago
There is just one discrepancy between the specified constants here and what we have in the #35 (Remove the debug settings for the submission) PR:
Debug constants in waypoint_updater.py:
I believe that the constant value set in the PR is actually the correct value, so we just need to reflect this in this issue. Thus, all is good with the settings for submission π
waypoint_updater.py:
LOOKAHEAD_WPS = 200
CIRCULAR_WPS = False
REFRESH_RATE_HZ = 50
DEBUG_MODE = False
TL_DETECTOR_ON = True
DECELLERATION = 3
tl_detector.py:
DETECTOR_ENABLED = True
DEBUG_MODE = False
PARKING_LOT_TEST = False
tl_classifier.py:
SIMULATOR_TRACK = False
IMAGE_CAPTURE = False
DEBUG_MODE = False
twist_controller.py:
GAS_DENSITY = 2.858
ONE_MPH = 0.44704
USE_YAW_CONTOLLER = False
The self-driving car (Carla) requires some specific rate of updates like in DBW:
Make sure that the project before submission meets the requirements.
Debug constants in
waypoint_updater.py
:REFRESH_RATE_HZ = 2
, should beREFRESH_RATE_HZ =10
?~REFRESH_RATE_HZ = 2
, should beREFRESH_RATE_HZ = 50
πUPDATE_MAX_ITER = 50
, should beUPDATE_MAX_ITER = 1
~WAYPOINT_INCREMENT_RATE = 5
, should beWAYPOINT_INCREMENT_RATE = 1
~DEBUG_MODE = False
, should beDEBUG_MODE = False
πTL_DETECTOR_ON = False
, should beTL_DETECTOR_ON = True
πDebug constants in
tl_detector.py
:DETECTOR_ENABLED = False
, should beDETECTOR_ENABLED = True
πDEBUG_MODE = False
, should beDEBUG_MODE = False
πPARKING_LOT_TEST = False
, should bePARKING_LOT_TEST = False
πDebug constants in
tl_classifier.py
:SIMULATOR_TRACK = True
, should beSIMULATOR_TRACK = False
πIMAGE_CAPTURE = False
, should beIMAGE_CAPTURE = False
πDEBUG_MODE= False
, should beDEBUG_MODE = False
~Debug constants in
twist_controller.py
:ENABLE_BRAKES = True
, remove and remove theif/else
conditions but leave theif
code block related~ not there anymoreUSE_YAW_CONTOLLER = False
remove it and related if/else block incontrol()
function , after we decide which controller will be used~USE_YAW_CONTOLLER = False
π