clockworklabs / com.clockworklabs.spacetimedbsdk

The SpacetimeDB SDK for C# clients
https://spacetimedb.com
Apache License 2.0
6 stars 0 forks source link

Unity Testsuite #176

Closed jdetter closed 4 weeks ago

jdetter commented 1 month ago

Description of Changes

Describe what has been changed, any new features or bug fixes

Update: reconnections have been fixed via https://github.com/clockworklabs/com.clockworklabs.spacetimedbsdk/pull/168 . In that PR I have enabled all tests!

I've used the built-in unity testsuite framework to achieve this, along with the UnityCI tool from GameCI. The documentation for this docker container can be found here: https://game.ci/docs/github/getting-started/

Rendered README for our testsuite which includes local testing instructions: https://github.com/clockworklabs/com.clockworklabs.spacetimedbsdk/blob/jdetter/unity-testsuite/unity-tests~/README.md

API

If the API is breaking, please state below what will break

Not breaking

Requires SpacetimeDB PRs

List any PRs here that are required for this SDK change to work

None

Testsuite

SpacetimeDB branch name: 0935b7346b825b8cbb9f36d9ed256136b73b5f0b

Testing

Write instructions for a test that you performed for this PR

jdetter commented 1 month ago

Ingvar suggested we add a check which verifies that the client bindings on the branch being tested are up-to-date, I agree with this and I've added the check.

cloutiertyler commented 1 month ago

@jdetter I am going to approve this, however, I am also going to schedule a meeting with @RReverser @SteveBoytsun @lcodes @Centril with the purpose of having you explain in person how it works, so that we can hand it off to others with them being able to understand the tricky problems of setting this up.

cloutiertyler commented 1 month ago

Should merge after this: https://github.com/clockworklabs/com.clockworklabs.spacetimedbsdk/pull/177

Centril commented 1 month ago

Rebased this atop of a rebased jdetter/unity-testsuite-import which was rebased atop of staging (https://github.com/clockworklabs/com.clockworklabs.spacetimedbsdk/pull/177#issuecomment-2446883581) and changed back the merge-into target branch to clarify the diff for review purposes.

Also changed the test-against stdb commit to 0935b7346b825b8cbb9f36d9ed256136b73b5f0b, currently the HEAD of master.

jdetter commented 4 weeks ago

closed in favor of https://github.com/clockworklabs/com.clockworklabs.spacetimedbsdk/pull/186