*1 not getting bound - Githubissues

clojure-emacs / ac-nrepl

[DEPRECATED] Emacs auto-complete backend for nrepl completions

74 stars 11 forks source link

*1 not getting bound #21

Closed deg closed 11 years ago

deg commented 11 years ago

In my nrepl buffer, with ac-nrepl, *1 is not getting bound to the results of the last expression evaluated. Instead, it is always ().

More details on the nrepl forum at https://github.com/kingtim/nrepl.el/issues/200. There, we identified that the bug appears to be connected to ac-nrepl.

purcell commented 11 years ago

Hi! I just tried, and I can't reproduce this; both entering code at the repl and evaluating code from a clojure buffer cause *1 to be bound inside the repl. Please can you provide a series of steps I can follow to see the same issue?

deg commented 11 years ago

I just did:

Start a fresh emacs
Create a new buffer /tmp/foo.clj
M-X nrepl jack in

Then, in nrepl: ; nREPL 0.1.6-preview user> (+ 3 4) 7 user> *1 () user>

That's about all the info I've got. Sounds like Tim King has a good handle on the issue, per his comments to my original bug report.

kingtim commented 11 years ago

@purcell I think I know what is causing the problem and I can submit a pull request to fix it. Should have it prepared a little later today. It is related to using nrepl-current-tooling-session for the ac-nrepl requests.

purcell commented 11 years ago

Right; when I simply try the above, I get this:

; nREPL 0.1.6-preview
user> (+ 3 4)
7
user> *1
7
user>

but if I do some completing at the repl, AC nrepl's background requests overwrite the 1, 2 etc for the repl session.

So I see what the issue is.

Closed by Tim's pull request #22, which I've now merged.