search

clojure-emacs / ac-nrepl

[DEPRECATED] Emacs auto-complete backend for nrepl completions
74 stars 11 forks source link

Display default nrepl quote on connection #31

Closed samaaron closed 11 years ago

purcell commented 11 years ago

Does it make sense for the autocompletion plugin to print out a "Connected" message? Won't the user see such a message in the nrepl REPL buffer anyway?

samaaron commented 11 years ago

Fair point.

The main reason I added it is that ac-nrepl overrides the default nrepl "connected" message with the "caching jvm classes" message. It seems nicer to have the nice nrepl message when everything's completed.

purcell commented 11 years ago

Ah, I see. I'd worry that it's wallpapering over the problem.

You know, I think we could do that classname caching asynchronously instead, and then we could skip the message altogether. The classname cache would just be unavailable until the asynchronous request completed.

samaaron commented 11 years ago

That sounds like a plan. I wouldn't know how to implement that though...

samaaron commented 11 years ago

And you're right - it is wallpapering over the problem! :-)

purcell commented 11 years ago

Alright, I think I've done it. Can you try the code in the cache-classes-asynchronously branch?

purcell commented 11 years ago

(The "Cached" message can probably be removed when we're sure it all works...)

purcell commented 11 years ago

I've merged and released my fix. Let me know if you have any problems with it. :-)