clojure-emacs / orchard

A fertile ground for Clojure tooling
Eclipse Public License 1.0
326 stars 54 forks source link

[inspector] Fix exception thrown when inspecting short Eduction #170

Closed alexander-yakushev closed 1 year ago

alexander-yakushev commented 1 year ago

Because Eduction type implements clojure.lang.Sequential but not clojure.lang.Counted, the inspector threw an exception when trying to inspect it. A minor but annoying bug. Besides, there could be other similar classes out there, so it's worth fixing.

Before submitting a PR make sure the following things have been done:

Thanks!

alexander-yakushev commented 1 year ago

This is a band-aid to prevent an exception thrown (and overall a fix that makes the underlying code more correct). Whether an Eduction should be rendered in the current way or differently can be discussed separately.

vemv commented 1 year ago

Tests are failing on Clojure master

Besides from that, all lgtm, if you want to expand the tests you are on time since I'll create an unrelated PR tomorrow, so it will get all in the same release train.

alexander-yakushev commented 1 year ago

Hmm, looks like a flaky test to me, I don't think I changed anything that could trigger that case.

alexander-yakushev commented 1 year ago

See, passed without changes:)

vemv commented 1 year ago

🍻!

With a bit of luck we'll have new orchard/cider-nrepl today/tomorrow

alexander-yakushev commented 1 year ago

🌳 🌳 🌳 🌳 🌳 🌳 🍎 🍎 🍎 🌳 🌳 🍺 🍺 🍺 🌳 🌳 🥴 🥴 🥴 🌳 🌳 🌳 🌳 🌳 🌳

vemv commented 1 year ago

https://clojars.org/cider/cider-nrepl/versions/0.34.0