Closed alexander-yakushev closed 1 year ago
This is a band-aid to prevent an exception thrown (and overall a fix that makes the underlying code more correct). Whether an Eduction should be rendered in the current way or differently can be discussed separately.
Tests are failing on Clojure master
Besides from that, all lgtm, if you want to expand the tests you are on time since I'll create an unrelated PR tomorrow, so it will get all in the same release train.
Hmm, looks like a flaky test to me, I don't think I changed anything that could trigger that case.
See, passed without changes:)
🍻!
With a bit of luck we'll have new orchard/cider-nrepl today/tomorrow
🌳 🌳 🌳 🌳 🌳 🌳 🍎 🍎 🍎 🌳 🌳 🍺 🍺 🍺 🌳 🌳 🥴 🥴 🥴 🌳 🌳 🌳 🌳 🌳 🌳
Because
Eduction
type implementsclojure.lang.Sequential
but notclojure.lang.Counted
, the inspector threw an exception when trying to inspect it. A minor but annoying bug. Besides, there could be other similar classes out there, so it's worth fixing.Before submitting a PR make sure the following things have been done:
Thanks!