search

clojure-emacs / orchard

A fertile ground for Clojure tooling
Eclipse Public License 1.0
326 stars 54 forks source link

Add a `Name` header to inspected Class objects #221

Closed vemv closed 11 months ago

vemv commented 12 months ago

Closes https://github.com/clojure-emacs/orchard/issues/217

Adds a Name header to inspected Class objects.

Also makes some tests less fragile - they were breaking on JDK 21.

Cheers - V

bbatsov commented 12 months ago

I'm kind of puzzled what exactly is the difference between "Name" and "Class", though, as it seem the name is derived from the class.

vemv commented 12 months ago

If we're inspecting the class object java.lang.String, its name is java.lang.String and its class is java.lang.Class

bbatsov commented 12 months ago

But inspecting classes will be the only case in which those 2 are different, right? I'm just wondering if "Name" is the right name for this.

vemv commented 12 months ago

Yes, only defmethod inspect :class is affected