search

clojurewerkz / spyglass

A Clojure Memcached client (also: Couchbase, Kestrel). Built on top of SpyMemcached, supports ASCII and binary protocols, strives to be 100% feature complete.
http://clojurememcached.info
67 stars 17 forks source link

Spyglass java client is far behind.. #11

Closed aterreno closed 10 years ago

aterreno commented 10 years ago

Hi, I was investigating a "net.spy.memcached.OperationTimeoutException" on our codebase and then noticed that the version is [spy/spymemcached "2.8.10"] while the latest is: [net.spy/spymemcached "2.10.4"]

The same applies to the couchbase client: [couchbase/couchbase-client "1.0.3"] vs [com.couchbase.client/couchbase-client "1.3.1"]

I've quickly tried upgrading and that breaks all tests :-(

Wondering if staying behind the clients version is intentional or due to the fact that as they state in their homepage "Note - as of the 2.9 (and 2.10) series, artifacts are published to Maven Central and the groupId has changed from "spy" to "net.spy""

https://code.google.com/p/spymemcached/

I doubt that the version might cause our timeout problem, I do wonder thought, since we are using the binary client if we should stick to an earlier version of memcached on the server too...

Thanks

michaelklishin commented 10 years ago

Recent releases did not work with SASL authentication on Heroku. I'm all for upgrading if we can verify that authentication is not broken (which is a major PITA to test because there is little documentation on how to build Memcached with authentication enabled).

aterreno commented 10 years ago

Oh, it's a bit obscure over there.. https://github.com/memcached/memcached/blob/master/Makefile.am#L30

I see... I'll create an issue over there, let's see if anybody is listening

aterreno commented 10 years ago

Oh, I might have managed to build it with SASL.. 

./autogen.sh
./configure --enable-sasl
make
./memcached -S

Starts fine on mac os.. I should probably try to do the same on a linux box and add perform the necessary sals setup..

michaelklishin commented 10 years ago

Just to make it clear: pull requests that update Spymemcached and Couchbase client dependencies are very welcome!

michaelklishin commented 10 years ago

It builds fine but then I observed obscure exception during authentication.

aterreno commented 10 years ago

yeah, I am there I suppose..

I get Invalid magic: 66 Invalid magic: 73

etc..

on memcached running with -vvv flag..

I'd love to send a pull request.. But I kind of doubt I'll make the tests pass, too much C/make blackmagic going on and zero docs..