cloud-software-foundation / c5

c5
Apache License 2.0
12 stars 8 forks source link

Mooring constructor blocks #277

Open joshua-g opened 10 years ago

joshua-g commented 10 years ago

The Mooring constructor blocks, but we want to be able to call it from a fiber. For instance, it is called from a fiber in LogService#getReplicatorLog. The constructor should be changed so it doesn't block -- perhaps separate out the logic to open the quorum into its own method; that method can return a future.

ryanobjc commented 10 years ago

We should beware of the 'dont partially construct an object' guideline -- it isnt a hard and fast rule, but the primary issue here is that people eventually forget to call a setup() or whatever method.