Move Go-API client library into the provider

cloudamqp / terraform-provider-cloudamqp

Terraform Provider for CloudAMQP

https://registry.terraform.io/providers/cloudamqp/cloudamqp

Mozilla Public License 2.0

35 stars 38 forks source link

Move Go-API client library into the provider #273

Closed tbroden84 closed 5 months ago

tbroden84 commented 6 months ago

WHY are these changes introduced?

No longer needed to share code within the Go-API client library to our other providers. Moving it into this provider will ease the development since no new versions needs to be released.

WHAT is this pull request doing?

Moves the Go-API client library into the provider
Cleans up code and logging.
More coherent code structure
- Declare variable within var()
- Make request
- Switch statement to handle response

HOW can this pull request be tested?

Tested again Go-VCR test fixtures and subset of new tests.

dentarg commented 6 months ago

I'm thinking we should import https://github.com/84codes/go-api with the git history

dentarg commented 6 months ago

I could make a PR for that, just adding the api/ directory (with history) and you could take it from there @tbroden84

tbroden84 commented 6 months ago

Sounds good.

dentarg commented 5 months ago

Sorry it took so long, PR with history is at https://github.com/cloudamqp/terraform-provider-cloudamqp/pull/282

dentarg commented 5 months ago

We now have https://github.com/cloudamqp/terraform-provider-cloudamqp/pull/284 and I think we can close this PR and remove this branch. I'll let you do that @tbroden84