search

cloudamqp / terraform-provider-cloudamqp

Terraform Provider for CloudAMQP
https://registry.terraform.io/providers/cloudamqp/cloudamqp
Mozilla Public License 2.0
35 stars 38 forks source link

Remove default subscription plan from VCR testing configuration #297

Closed tbroden84 closed 2 months ago

tbroden84 commented 2 months ago

WHY are these changes introduced?

To use the same instance resource VCR test configuration for both backends. This force each configuration to include the subscription plan to be used.

WHAT is this pull request doing?

Remove the default subscription plan from instance*.txt configuration. Add the subscription plan to all tests.

HOW can this pull request be tested?

Run VCR tests.

tbroden84 commented 2 months ago

Unless we need more specific settings for LavinMQ. Help to remove extra files created in: https://github.com/cloudamqp/terraform-provider-cloudamqp/pull/296

viktorerlingsson commented 2 months ago

Unless we need more specific settings for LavinMQ. Help to remove extra files created in: #296

This should do fine for LavinMQ as well. I was just testing with the exact same change in instance.txt and instance_with_version.txt :)

(see https://github.com/cloudamqp/terraform-provider-cloudamqp/pull/296/commits/6d0334d5204e0e334e0fd790f67cde3814a18804 )