search

cloudant-labs / cloudant-python

Asynchronous Cloudant / CouchDB interface for Python
http://cloudant-labs.github.io/cloudant-python/
37 stars 17 forks source link

Deprecates the 0.5.x branch of the cloudant python library. #56

Closed gadamc closed 8 years ago

gadamc commented 8 years ago

What: Prepares for deprecation of 0.5.x

How: Adds warnings to both READMEs. Updates the version number in setup.py to 0.5.10 Adds warning to init.py which prints to stderr.

After this PR is merged to master, we'll push it up to PyPI.

reviewers: @alfinkel @mikerhodes

mgmarino commented 8 years ago

Hi @gadamc, any public branch where the proposed changes/updates to the API are or will be? It would be nice to be able to prepare/comment.

alfinkel commented 8 years ago

@mgmarino https://github.com/cloudant/python-cloudant is now public.

mgmarino commented 8 years ago

@alfinkel Thanks!

gadamc commented 8 years ago

The Travis build error is reproducible locally and when I created a new branch/PR with zero effective changes from master.

https://travis-ci.org/cloudant-labs/cloudant-python/builds/85609492

Perhaps this test passed previously with a different version of couchdb and now fails with the latest version of couchdb?

Regardless, I think we should ignore this build failure for this particular PR.

alfinkel commented 8 years ago

@gadamc, It looks like the same version of CouchDB (1.6.1) was used for this PR build as was used with the last successful master branch build about 9 months ago. But I do agree with you about the course of action on the build failure. It is just the one test that has an issue and from what I can tell, this issue has been around since before we added changes from this PR. Maybe @mikerhodes can provide some feedback here. Since we're in the midst of deprecating this library, does it make sense to spend time on fixing issues in it?

gadamc commented 8 years ago

@mikerhodes still waiting for you here.

alfinkel commented 8 years ago

+1

mikerhodes commented 8 years ago

I think we can merge this one, +1, without fixing the build.

It'd be good to track down the source of the issue, however, odd that the _changes feed heartbeats would change -- might just be we need to update the expected values to be more lenient in the new library version too.

gadamc commented 8 years ago

@mikerhodes -- You'll have to do the actual merge since I don't seem to have write privileges to this repository.

After that is complete, let me know and I can push to PyPI if you like (of course, you or @alfinkel can push it as well if you like).