cloudant / sync-android

A JSON-based document datastore for Android applications
Apache License 2.0
267 stars 90 forks source link

Apply 2.x specific tests to CouchDB 3.x #608

Closed jjrodrig closed 4 years ago

jjrodrig commented 4 years ago

Checklist

Description

During testing on new CouchDB 3.x, I've noticed that some tests are skipped. These tests only run in a CouchDB 2.x.

This PR extends the version checking to 3.x for those tests.

Approach

Schema & API Changes

No change

Security and Privacy

No change

Testing

The following tests should pass in Couchdb 2.x and 3.x

changes_dbChangesMustSuccessfullyReturnWithSeqInterval changes_selector changes_selectorAndMoreThanLimitNumberOfDocs pull_filterDocIdsFromAnimalDb_twoDocShouldBePulled pull_filterSelectorMammalFromAnimalDbUsingParameterizedFilter_eightDocShouldBePulled pull_filterSelectorBirdFromAnimalDb_twoDocShouldBePulled pull_filterSelectorMammalFromAnimalDbUsingParameterizedFilter_eightDocShouldBePulled pull_filterSelectorSmallFromAnimalDbUsingIntegerFilter_eightDocShouldBePulled pull_filterSelectorSmallFromAnimalDbUsingNullFilter_eightDocShouldBePulled

Monitoring and Logging

No change

bessbd commented 4 years ago

I'm about to merge this.