search

cloudbase / garm

GitHub Actions Runner Manager
Apache License 2.0
127 stars 25 forks source link

handle the ping github event #291

Open rgl opened 1 week ago

rgl commented 1 week ago

after adding a repo with:

./garm-cli repo add \
  --credentials rgl \
  --owner rgl \
  --name terraform-azure-garm-example-repository \
  --install-webhook \
  --random-webhook-secret

the garm logs started to show these log lines:

time=2024-09-22T06:39:06.868Z level=INFO msg="ignoring unknown event" gh_event=ping

can garm handle them instead of logging them as a unknown event?

gabriel-samfira commented 1 week ago

Hi @rgl

Sure. We never did because we return 200 even if we ignore the event. The ping event is sent after a webhook is added in github to confirm that the endpoint is there and accepts connections. If the endpoint returns 200, in Github you will have a green checkmark confirming it works. I don't think github sends any other pings unless requested.

On our side there is nothing we need to do with that ping except log it. Maybe change the log message to not say "unknown".