search

cloudbase / windows-imaging-tools

Tools to automate the creation of a Windows image for OpenStack, supporting KVM, Hyper-V, ESXi and more.
Apache License 2.0
670 stars 227 forks source link

Fixed multiple iso mount points for VirtIO #345

Closed ader1990 closed 4 years ago

ader1990 commented 4 years ago

If multiple images are generated using the same VirtIO ISO, there is a chance that the imaging tool will dismount the VirtIO ISO at a path in use, which triggers an error to apply the drivers.

Copying the ISO to a backup file and mounting that ISO will fix the issue.

This fix might be time / space consuming, but it is the only way to make sure that the proper ISO is unmounted, as there is no way to get the mount point from the ISO file path itself, without making a persistance layer logic to track which ISO file corresponds to which mount point and make another persistence layer to track the mount points. Even if the mount points and file paths are tracked, in highly used envs, there is a probability that the mount points cannot be properly tracked due to concurrency issues (when 2 ISOs are mounted at the +- epsilon time), which is exactly what we want to avoid.

AppVeyorBot commented 4 years ago

:white_check_mark: Build windows-openstack-imaging-tools 1.0.249 completed (commit https://github.com/cloudbase/windows-openstack-imaging-tools/commit/30d0098498 by @ader1990)