Closed llbrt closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
ℹ️ Googlers: Go here for more info.
Merging #180 into master will increase coverage by
0.17%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #180 +/- ##
============================================
+ Coverage 80.06% 80.24% +0.17%
- Complexity 1715 1721 +6
============================================
Files 159 159
Lines 5718 5734 +16
Branches 754 757 +3
============================================
+ Hits 4578 4601 +23
+ Misses 856 849 -7
Partials 284 284
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
.../server/spi/response/RestResponseResultWriter.java | 100% <100%> (ø) |
6 <0> (+1) |
:arrow_up: |
...va/com/google/api/server/spi/ServiceException.java | 80.35% <100%> (+17.56%) |
16 <8> (+4) |
:arrow_up: |
...gle/api/server/spi/response/ConflictException.java | 14.28% <0%> (+14.28%) |
1% <0%> (+1%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 39b7374...6ec9b5b. Read the comment docs.
I signed it!
Wrong email address in commit
The goal of these changes is to be able to add some extra fields in ServiceException, to give more details about the error. These fields may be documented by the service and used on the client side (diagnosis, help, ...).
For example, the field 'extendedHelp' in this reply