cloudendpoints / endpoints-java

A Java framework for building RESTful APIs on Google App Engine
Apache License 2.0
32 stars 35 forks source link

refactor and cleanup API config validation #47

Closed tangiel closed 7 years ago

tangiel commented 7 years ago

This change moves config validation out of JsonConfigWriter into ApiConfigValidator. JsonConfigWriter is mostly deprecated at this point, with no need for the older JSON API config with discovery and Swagger generation being created without it.

codecov-io commented 7 years ago

Codecov Report

Merging #47 into master will increase coverage by -0.06%.

@@             Coverage Diff              @@
##             master      #47      +/-   ##
============================================
- Coverage     79.74%   79.68%   -0.06%     
============================================
  Files           153      153              
  Lines          5407     5411       +4     
  Branches        696      693       -3     
============================================
  Hits           4312     4312              
- Misses          821      829       +8     
+ Partials        274      270       -4
Impacted Files Coverage Δ Complexity Δ
...oogle/api/server/spi/tools/GenApiConfigAction.java 30.76% <ø> (-1.67%) 0 <ø> (-2)
...rver/spi/config/validation/ApiConfigValidator.java 77.58% <100%> (+2.42%) 0 <ø> (-55) :x:
...server/spi/config/jsonwriter/JsonConfigWriter.java 67.66% <100%> (-0.95%) 0 <ø> (-56)
.../java/com/google/api/server/spi/SystemService.java 82.26% <100%> (-0.53%) 0 <ø> (-39)
...oogle/api/server/spi/swagger/SwaggerGenerator.java 76.55% <100%> (+0.22%) 0 <ø> (-51) :x:
...ain/java/com/google/api/server/spi/TypeLoader.java 94.54% <75%> (-0.74%) 0 <ø> (-18)
...pi/server/spi/config/model/ApiParameterConfig.java 85% <ø> (-1.25%) 0% <ø> (-33%)
...e/api/server/spi/config/model/ApiMethodConfig.java 87.03% <ø> (-0.62%) 0% <ø> (-65%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a79526...97b4486. Read the comment docs.