cloudentity / oauth2c

User-friendly OAuth2 CLI
https://cloudentity.github.io/oauth2c/
Apache License 2.0
741 stars 29 forks source link

Move internal to pkg to allow library re-use #104

Closed maordavidov closed 6 months ago

maordavidov commented 6 months ago

The usage of internal does not allow us to re-use the packages in other go applications. Changing to pkg will allow us to reference the source code in other applications as well.

mbilski commented 6 months ago

Hi @maordavidov

We are using the internal on purpose. That way, we are not obligated to maintain backward compatibility, and we can make any changes we want there.

What functionalities are you looking for to re-use from the oauth2c internal package? I would instead expose only some of the internal functionalities in pkg using a new abstract interface so that way we can limit the api we need to keep backward compatible to a bare minimum.

maordavidov commented 6 months ago

I see, in that case I will close the PR, I already found a workaround to use the entire command as sub command and forward the stdout.