search

cloudera / clusterdock

Apache License 2.0
70 stars 57 forks source link

passing '--help' to the run script produces a container when it probably shouldn't #12

Open davidholiday opened 7 years ago

davidholiday commented 7 years ago

in the case where the user is explicitly passing the help argument to the run script, it can be safely assumed that she intends only to read the help text, not create a container.

ex: 

[dholiday@wintermute: ~/gitclones/clusterdock]$ docker ps -a
CONTAINER ID        IMAGE                      COMMAND                  CREATED             STATUS                         PORTS               NAMES
[dholiday@wintermute: ~/gitclones/clusterdock]$ clusterdock_run ./bin/start_cluster cdh --help
Password:
usage: start_cluster cdh [-h] [--primary-node NODES] [--secondary-nodes NODES]
                         [--cdh-string cdh] [--cm-string cm]
                         [--dont-start-cluster]
                         [--exclude-service-types svc1,svc2,...]
                         [--include-service-types svc1,svc2,...]

optional arguments:
  -h, --help            show this help message and exit
  --primary-node NODES  Nodes of the primary-node group (default: ['node-1'])
  --secondary-nodes NODES
                        Nodes of the secondary-nodes group (default:
                        ['node-2'])

  --cdh-string cdh      CDH version to use (default: cdh580)
  --cm-string cm        CM version to use (default: cm581)
  --dont-start-cluster  Don't start clusters/services in Cloudera Manager
                        (default: False)
  --exclude-service-types svc1,svc2,...
                        If specified, a comma-separated list of service types
                        to exclude from the CDH cluster (default: None)
  --include-service-types svc1,svc2,...
                        If specified, a comma-separated list of service types
                        to include in the CDH cluster (default: None)
[dholiday@wintermute: ~/gitclones/clusterdock]$ docker ps -a
CONTAINER ID        IMAGE                                   COMMAND                  CREATED             STATUS                         PORTS               NAMES
e2feb4baa1f0        docker.io/cloudera/clusterdock:latest   "python ./bin/start_c"   9 seconds ago       Exited (0) 7 seconds ago                           sharp_brown
[dholiday@wintermute: ~/gitclones/clusterdock]$