search

cloudevents / sdk-csharp

CSharp SDK for CloudEvents
Apache License 2.0
272 stars 77 forks source link

Make library AOT compatible #272

Open giggio opened 9 months ago

giggio commented 9 months ago

Right now we are getting warnings, like:

/home/user/.nuget/packages/cloudnative.cloudevents.systemtextjson/2.7.1/lib/netstandard2.1/CloudNative.CloudEvents.SystemTextJson.dll : warning IL2104: Assembly 'CloudNative.CloudEvents.SystemTextJson' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/app/consumer.csproj]
/home/user/.nuget/packages/cloudnative.cloudevents.systemtextjson/2.7.1/lib/netstandard2.1/CloudNative.CloudEvents.SystemTextJson.dll : warning IL3053: Assembly 'CloudNative.CloudEvents.SystemTextJson' produced AOT analysis warnings. [/app/consumer.csproj]
jskeet commented 9 months ago

I'm afraid I don't have enough experience with AOT (or time to get up to speed) to work on this. I'd happily review a PR to address it, however.

giggio commented 8 months ago

@jskeet I just added a PR for it, it was a lot of work, I need revision to make sure everything is ok.