search

cloudevents / sdk-go

Go SDK for CloudEvents
https://cloudevents.github.io/sdk-go/
Apache License 2.0
835 stars 220 forks source link

CESQL v1 fixes #1066

Closed Cali0707 closed 4 months ago

Cali0707 commented 5 months ago

This PR updates the CESQL implementation here to match the changes made in the spec v1 that was approved today. Since there are a lot of changes, I've tried to organize them by commit

Cali0707 commented 5 months ago

There is one more change I would like to include (either as a follow up or in this PR), but I wasn't sure what the API should be for it:

Currently this SDK only supports the "fail fast" error handling mode, where the CESQL engine returns as soon as it encounters an error. However, I would like to allow users to choose which error handling strategy they would like to use (and then maybe default to fail fast to avoid breaking changes as much as possible). Any ideas on what a good API could be for that?

Cali0707 commented 5 months ago

cc @duglin @pierDipi @embano1

duglin commented 5 months ago

rebase is needed

Cali0707 commented 4 months ago

@duglin can you re-check?

lionelvillard commented 4 months ago

@duglin for second approval/merge

matzew commented 4 months ago

LGTM, thanks for the work, @Cali0707

duglin commented 4 months ago

rebase needed

duglin commented 4 months ago

Just a few minor comments, none should stop this from being merged though. so LGTM once the rebase is one and @Cali0707 says it's ready to go after looking at the comments.