search

cloudevents / spec

CloudEvents Specification
https://cloudevents.io
Apache License 2.0
5.1k stars 586 forks source link

clarify type casting in CESQL spec #1281

Closed Cali0707 closed 5 months ago

Cali0707 commented 6 months ago

Follow up on discussion in https://github.com/cloudevents/sdk-go/pull/1046#discussion_r1589256405

Proposed Changes

Cali0707 commented 6 months ago

cc @pierDipi @duglin

Cali0707 commented 6 months ago

cc @duglin @jskeet

Let me know if this makes sense given your feedback last week!

duglin commented 6 months ago

Error looks real: cesql/spec.md: line 365: 'may' MUST be capitalized ('MAY')

Cali0707 commented 5 months ago

@duglin how does this look now?

duglin commented 5 months ago

Just one question, but either way that one lands.... LGTM -thanks!

duglin commented 5 months ago

Approved on the 5/30 call