cloudflare / argo-tunnel-examples

209 stars 78 forks source link

feat: improve helm chart #23

Closed Demonsthere closed 9 months ago

Demonsthere commented 2 years ago

Hi there! A small PR with 2 features that i found useful :) :

holms commented 1 year ago

@nmldiegues maybe this could be approved? It's totally makes sense.

5cat commented 1 year ago

This pull request is essential, without it the chart is useless. Passing secrets as a plain text in a helm values file is insecure, this pull request provides a way to pass the secret name instead of the value, so I can use external-secret to set it and store it without having to hard code it in the helm values file. @eidam @chungthuang @adamchalmers

gitguardian[bot] commented 9 months ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | 763d4567f72be65adaabbd34e555c326e6f1d836 | helm/cloudflare-tunnel/overrides.yaml | [View secret](https://github.com/cloudflare/argo-tunnel-examples/commit/763d4567f72be65adaabbd34e555c326e6f1d836#diff-0b99ba610c403a214779e05add56a030L9) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!