Fix SSL curve identifiers

cloudflare / boring

BoringSSL bindings for the Rust programming language.

364 stars 110 forks source link

Fix SSL curve identifiers #239

Closed jrouviere closed 3 months ago

jrouviere commented 5 months ago

While testing I noticed that SslRef::curve() was returning 29 (SSL_CURVE_X25519) instead of 948 (NID_X25519). I assume most users rely on SslCurve::name() which is correct because it's passing the id back to the ffi layer.

bwesterb commented 5 months ago

This breaks set_curves, which expects NIDs.

rushilmehra commented 4 months ago

CI is borked, I'm trying to fix it in https://github.com/cloudflare/boring/pull/240. Let's hold off on merging this until CI is fixed