cloudflare / pint

Prometheus rule linter/validator
https://cloudflare.github.io/pint/
Apache License 2.0
879 stars 53 forks source link

Revert "Force colored output unless explicitly disabled" #1136

Closed prymitive closed 1 month ago

prymitive commented 1 month ago

This reverts commit c5dcd86850c6f534ed06fec3a1b21f3a126a39a3.

github-actions[bot] commented 1 month ago

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   40.75m ± 1%   39.96m ± 4%  -1.94% (p=0.035 n=10)
CheckRules-4     8.498 ± 2%    8.509 ± 2%       ~ (p=0.684 n=10)
geomean         588.5m        583.1m       -0.91%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.41Mi ± 0%   27.41Mi ± 0%       ~ (p=0.853 n=10)
CheckRules-4    977.8Mi ± 0%   978.3Mi ± 0%       ~ (p=0.436 n=10)
geomean         163.7Mi        163.7Mi       +0.03%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.9k ± 0%   131.9k ± 0%       ~ (p=0.926 n=10)
CheckRules-4    14.20M ± 0%   14.20M ± 0%       ~ (p=0.280 n=10)
geomean         1.368M        1.368M       +0.01%
codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.16%. Comparing base (9ae98f9) to head (b1bcc7c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1136 +/- ## ========================================== - Coverage 95.16% 95.16% -0.01% ========================================== Files 102 102 Lines 10236 10234 -2 ========================================== - Hits 9741 9739 -2 Misses 346 346 Partials 149 149 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.