cloudflare / pint

Prometheus rule linter/validator
https://cloudflare.github.io/pint/
Apache License 2.0
880 stars 53 forks source link

Improve alerts/template messages #1177

Closed prymitive closed 1 month ago

github-actions[bot] commented 1 month ago

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   40.16m ± 2%   39.98m ± 1%       ~ (p=0.280 n=10)
CheckRules-4     8.534 ± 2%    8.530 ± 2%       ~ (p=0.579 n=10)
geomean         585.4m        583.9m       -0.25%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.41Mi ± 0%   27.41Mi ± 0%       ~ (p=1.000 n=10)
CheckRules-4    971.9Mi ± 0%   971.6Mi ± 0%       ~ (p=0.739 n=10)
geomean         163.2Mi        163.2Mi       -0.02%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.9k ± 0%   131.9k ± 0%       ~ (p=0.544 n=10)
CheckRules-4    14.12M ± 0%   14.12M ± 0%       ~ (p=0.971 n=10)
geomean         1.365M        1.365M       -0.00%
codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.91%. Comparing base (bbca330) to head (af75bbc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1177 +/- ## ========================================== - Coverage 94.91% 94.91% -0.01% ========================================== Files 104 104 Lines 12366 12358 -8 ========================================== - Hits 11737 11729 -8 Misses 480 480 Partials 149 149 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.