search

cloudflare / templates

A collection of starter templates and examples for Cloudflare Workers and Pages
https://cloudflareworkers.com
MIT License
999 stars 632 forks source link

bugfix: remove invalid chars from wrangler.toml #64

Closed jwdeane closed 2 years ago

jwdeane commented 2 years ago

Steps to Reproduce

  1. Clone repo
  2. Change into an example dir e.g. cd worker-typescript
  3. Install deps npm i
  4. Fire up dev mode npx wrangler dev src/index.ts --local
  5. Alternatively just visit https://workers.new/typescript and you'll see the below error in the console:
$ wrangler dev src/index.ts --local
 ⛅️ wrangler 2.0.1 
-------------------

✘ [ERROR] Processing wrangler.toml configuration:

    - Expected "name" to be of type string, alphanumeric and lowercase with dashes only but got "<<
  todo >>".

PR removes all occurrences of << todo >> in each examples wrangler.toml.

lukeed commented 2 years ago

Interesting. I guess this changed between the latest beta release and latest.

Thanks for this. Can you please update the tomls again and place a # TODO next to each now-empty string?

eidam commented 2 years ago

thank you! merging, gonna create new PR with comments