rameardo
commented
4 months ago Hello Philip Walton!
You encountered this issue because you need to:
- Ensure the
fetchmethod follows redirects correctly by setting theredirectoption to manual or handling it in a different way. - Use
fetchoptions to prevent automatic following of redirects to handle them explicitly if needed.
Let's go through the solution step by step. First, modify your code as follows:
worker.js should look like this (your code is ok):
export default {
async fetch(request) {
const url = new URL(request.url);
console.log('incoming request') // to see in console
if (url.pathname === '/needs-redirect') {
url.pathname = '/redirected';
return Response.redirect(url.href, 301);
}
return new Response('Hello!');
},
};Next, update your index.js:
import { unstable_dev } from 'wrangler';
const worker = await unstable_dev('./worker.js', {
experimental: { disableExperimentalWarning: true },
});
const response = await worker.fetch('/needs-redirect', { redirect: 'manual' }) // prevent automatic following by option redirect: 'manual'
if (response.status === 301)
console.log('Redirected to:', response.headers.get('Location'));
else
console.log('Response status:', response.status);Testing the Setup
Open two terminals in your project directory.
In the first terminal, run your worker locally on localhost with port 3000:
$ wrangler dev --host=localhost --port=3000 ./worker.jsIn the second terminal, run your index.js with the following command:
node index.jsoutput
You should see the following outputs:
In the first terminal:
>wrangler dev --host=localhost --port=3000 ./worker.js
⛅️ wrangler 3.56.0
-------------------------------------------------------
⎔ Starting local server...
[wrangler:inf] Ready on http://127.0.0.1:3000In the second terminal:
>node index.js
Redirected to: http://placeholder/redirectedCheers, Adnan
philipwalton
penalosa
Which Cloudflare product(s) does this pertain to?
Wrangler core
What version(s) of the tool(s) are you using?
3.56.0 [Wrangler]
What version of Node are you using?
v20.11.0
What operating system and version are you using?
macOS sonoma 14.4.1 (23E224)
Describe the Bug
Observed behavior
When calling
return Response.redirect(url.href, 301)from within Worker code, I'm getting errors, both when using theunstable_devAPI as well as when usingwrangler devwith a custom local host specified.Expected behavior
My redirect code fully worked with v2 of wrangler, but after upgrading to v3 I'm getting errors in both my tests and my local dev environment.
Steps to reproduce
node index.js(if it doesn't happen automatically)Here is the contents of the worker file in the repro:
In addition to the error shown above when using
unstable_dev, I'm also seeing errors for the same worker file when runningwrangler devlocally with a local host specified:Then, if I use
curlto test the redirect, I get an invalidLocationheader returned with the response. See the following screenshot:Notice how path was property updated by the redirect logic in the worker, but the URL in the
Locationheader is invalid, as it now includes port 3000 appended to the existing port (which is also repeated for some reason). This also did not happen when using wrangler v2.Please provide a link to a minimal reproduction
https://stackblitz.com/edit/stackblitz-starters-vjsh9a?file=index.js
Please provide any relevant error logs
Error when using
unstable_dev:Invalid response when running wrangler with host
localhost:3000specified: