cloudfoundry-attic / warden

Cloud Foundry - the open platform as a service project
Apache License 2.0
283 stars 108 forks source link

Remove Idle timeouts #101

Closed ghost closed 9 years ago

ghost commented 9 years ago

The concerns for this issue are:

The original PR can be found here.

The PR has been reverted a second time at Warden commit and the corresponding DEA commit.

The reason we reverted the commits is due to the fact that DEA's started to crash after a couple of hours under load. The root problem seems to be that connections between the DEA and Warden are not being properly closed and the DEA relied on the timeout connections to clean things up. We believe a better solution is to go through and make sure that all of the connections that are created between these components are correctly receiving a close connection call.

Note: Some offending log lines that appeared had the message Too many open files.

cf-gitbot commented 9 years ago

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/101615158.

fraenkel commented 9 years ago

Just revert yet again to remove the timeouts. The DEA PR will handle the rest.

https://github.com/cloudfoundry/dea_ng/pull/172

jpalermo commented 9 years ago

Merged along with https://github.com/cloudfoundry/dea_ng/pull/172

jpalermo commented 9 years ago

Merged https://github.com/cloudfoundry/warden/commit/d9065ba9df3261517a2ababdb66ca22345d4b94d