search

cloudfoundry-attic / warden

Cloud Foundry - the open platform as a service project
Apache License 2.0
283 stars 108 forks source link

Feature/add container timeout #108

Closed ndemeshchenko closed 7 years ago

ndemeshchenko commented 8 years ago

There are some cases when app is not able to gracefully stop in 10 seconds, which is hardcoded in stop.sh and SIGKILL is not the best solution for this. This pull request exposing the wait params to warden config.

cfdreddbot commented 8 years ago

Hey ndemeshchenko!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

cf-gitbot commented 8 years ago

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/117442309.

fraenkel commented 8 years ago

@ndemeshchenko Thank you for the pull request.

  1. You need to sign the CLA before any action can be taken.
  2. A change like this should have been discussed since it affects Diego as well. The Diego project would also need to accept a similar change before anything could be done to Warden.

See https://github.com/cloudfoundry-incubator/executor/blob/62e0a3e095df69ba317af078eb3cf486b8895562/depot/steps/run_step.go#L180

ndemeshchenko commented 8 years ago

@fraenkel thanks for you response for 1 sure, I will complete the CLA, thx for pointing but 2 is not completely clear, does that mean that along with this pull request another one for diego should be provided. Or it just should be discussed? Kindly advise on what I can do further Thanks much.

fraenkel commented 8 years ago

You need to have this discussed with the Diego team first since the behaviors need to be aligned.

ndemeshchenko commented 8 years ago

hi @fraenkel, I was trying to get in touch with diego team but no success so far. can you please advise the right approach to ping them.

thanks much

fraenkel commented 8 years ago

You can try to reach out directly to emalm on slack.

garden-gnome commented 7 years ago

Hi there!

We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created.

The current status is as follows:

This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes.

julz commented 7 years ago

Closing this since it's inactive now and warden is no longer supported.