cloudfoundry-attic / warden

Cloud Foundry - the open platform as a service project
Apache License 2.0
283 stars 108 forks source link

Allow fuse device to be used inside containers #70

Closed aristotelesneto closed 10 years ago

cf-gitbot commented 10 years ago

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/73847508.

mkocher commented 10 years ago

In general we've been holding off on as much that can be deferred until after diego launches to prevent moving the goalposts and having to do work twice. This does seem like a fairly small change to enable fuse though, so it might be doable.

@onsi @vito any concerns/guidance about making these same changes in https://github.com/cloudfoundry-incubator/garden?

aristotelesneto commented 10 years ago

This PR needs to be done in conjunction with the stack change.

fraenkel commented 10 years ago

@wdneto There are no tests, so how do we know that fuse is installed and configured properly?

aristotelesneto commented 10 years ago

Hi @fraenkel

You're correct. I couldn't find tests for the other 'standard linux functionality' so I assumed it wasn't needed, provided that it had been manually tested to work following the bootstrap deb package install on rootfs / mknod creation.

I'm struggling to find where and how to test solely from within warden. Are you able to provide me with some guidance?

fraenkel commented 10 years ago

@wdneto As you have seen we don't directly test any of this. However, all the packages included are needed by either DEA/Warden, a buildpack, or historical. This would be one of the first things that provide us no guarantees which is a major issue. Is there some simple test, app, whatever that could drive fuse?

aristotelesneto commented 10 years ago

Hi @fraenkel

We could test that fuse is indeed working by running:

mount -t fusectl none /fuse_ctl
fusermount -u /fuse_ctl

Or by mounting the 'hello' sample filesystem.

Would that be sufficient?

Alternatively, we could spin up an ssh daemon and run sshfs as part of the dea code?

aristotelesneto commented 10 years ago

Awesome, thanks @sykesm for writing the test.