search

cloudfoundry-attic / warden

Cloud Foundry - the open platform as a service project
Apache License 2.0
283 stars 108 forks source link

Use wait-for-lock when invoking iptables #99

Closed fraenkel closed 9 years ago

fraenkel commented 9 years ago

[#78487348]

cfdreddbot commented 9 years ago

Hey fraenkel!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

cf-gitbot commented 9 years ago

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/98771166.

vito commented 9 years ago

there's also https://github.com/cloudfoundry/warden/blob/e04877593a16828fc7f4931177e82dee76cf509c/warden/root/linux/skeleton/net.sh#L86 which is how this has been working the whole time. iirc we removed that in favor of -w in garden

fraenkel commented 9 years ago

@vito That did not guard cross network interfaces. We were seeing collisions with the flock.

vito commented 9 years ago

yeah, was more wondering if the -w made it redundant