search

cloudfoundry-community / firehose-to-syslog

Send firehose events from Cloud Foundry to syslog.
MIT License
44 stars 58 forks source link

Suffix Stripping using a Regex instead of HasSuffix Function #198

Open Scoobed opened 6 years ago

Scoobed commented 6 years ago

Suffix Stripping is currently using strings.HasSuffix Function

The issue is in our environment as we push our applications the product that pushes our builds adds a suffix like [AppName]-new-build-XXXXXX-venerable so using the HasSuffix Function will only remove one piece. If we use a regex expression instead, we could be more dynamic in the removal.

https://github.com/cloudfoundry-community/firehose-to-syslog/commit/e824aae037e942efd6660a677d6c1a5761119bd5

shinji62 commented 6 years ago

@Scoobed I understand but I would like to avoid to add to much transformation / regexp

Wondering what will happen for nozzle which handle 10K msg/s ? How this will impact the perf ?

Thanks

Scoobed commented 6 years ago

Currently working to push a bosh dev release in our test environment with the straight 5.0.0 so we test what is there. We might try a pull request with regex instead or maybe be able to flip the two to get a better picture of the performance hit of each

shinji62 commented 6 years ago

When you will be sure that no real impact on perf. Then I will accept the PR.

Scoobed commented 6 years ago

Ok, we have the Dev release with the 5.0.0 Binary running matching this release in two environments. I was having a question on how would I get my forked Binary 5.0.1 into the logsearch-for-cloudfoundry release without you needing to merge it here first?