Optional repository prefix - Githubissues

cloudfoundry-incubator / fissile

Turn a BOSH release into container images / files

Apache License 2.0

67 stars 36 forks source link

Optional repository prefix #476

Closed f0rmiga closed 5 years ago

f0rmiga commented 5 years ago

Description

Adds the possibility of --repository being empty. Also, changes the --repository default from fissile to empty string.

Test plan

Create the nats image without setting the repository, should get an image something/nats:

fissile build release-images \
  --stemcell="splatform/fissile-stemcell-opensuse" \
  --name="nats" \
  --version=26 \
  --sha1=2f2c27acdfff81f3519968921686522518ab5783 \
  --url="https://bosh.io/d/github.com/cloudfoundry/nats-release?v=26" \
  --docker-organization="something"

Create the nats image setting the repository, should get an image something/myprefix-nats:

fissile build release-images \
  --stemcell="splatform/fissile-stemcell-opensuse" \
  --name="nats" \
  --version=26 \
  --sha1=2f2c27acdfff81f3519968921686522518ab5783 \
  --url="https://bosh.io/d/github.com/cloudfoundry/nats-release?v=26" \
  --docker-organization="something" \
  --repository="myprefix"

cfdreddbot commented 5 years ago

:white_check_mark: Hey f0rmiga! The commit authors and yourself have already signed the CLA.