search

cloudfoundry / bosh-google-cpi-release

BOSH Google CPI
Apache License 2.0
63 stars 96 forks source link

Remove the usage of hardcoded mincpuplatform values #329

Closed dimitdb closed 2 years ago

dimitdb commented 2 years ago

I would like to no longer pass mincpuplatform in the call to create a VM. This is causing issues when CPI is asked to create gen2 VM (n2) in any of the following zones: us-central1-a and europe-west1-b. Here is the error, returned by the google API:

googleapi: Error 400: The selected machine type (n2-custom-2-4096) has a required CPU platform of cascadelake. The minimum CPU platform must match this, but was broadwell.

The need for having the map minCpuPlatform, that specifies min CPU platform "Intel Broadwell" for zones us-central1-a and europe-west1-b appears to be no longer valid. Based on the test, I've performed, the mincpuplatform in both zones now defaults to Intel Broadwell (not Sandy Bridge), when trying to create a gen1 VM.

linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers are authorized under a signed CLA.

dimitdb commented 2 years ago

Related to #322

friegger commented 2 years ago

@ramonskie should this PR go against the develop branch?

rkoster commented 2 years ago

Thanks! @dimitdb