search

cloudfoundry / bpm-release

isolated bosh jobs
Apache License 2.0
34 stars 28 forks source link

Fix volume validation for `additional_volumes` #138

Closed jfmyers9 closed 4 years ago

jfmyers9 commented 4 years ago

This change fixes the pathIsIn function to properly fail if a path is not nested within one of the provided paths. This change is potentially a breaking change due to the fact that this bug has been around for a long period of time.

Note: This change also relaxes the validation for volumes to ensure that they are nested within /var/vcap. This is an unfortunate side effect of this bug as it will be a breaking change for a good number of users that have been relying on the broken behavior.

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/171110820

The labels on this github issue will be updated when the story is started.