search

cloudfoundry / cf-mysql-release

Cloud Foundry MySQL Release
Apache License 2.0
58 stars 106 forks source link

BBR support #191

Open gberche-orange opened 7 years ago

gberche-orange commented 7 years ago

Hi Core Services team,

I'm wondering whether there are plans to add BBR support for cf-mysql-release.

I could not yet find mention of it into the issues, tracker, or pmc-notes , on slack, or in BBR backlog

If not, please let me know if such contribution could be accepted.

Thanks in advance,

Guillaume.

/cc @ldangeard-orange

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/152758081

The labels on this github issue will be updated when the story is started.

gberche-orange commented 6 years ago

@menicosia any feedback you could provide ?

menicosia commented 6 years ago

Hi @gberche-orange, sorry for taking so long to get back to you.

Because BBR intends for the deployment to be aware that a backup is occurring, and respond appropriately, (for instance ccdb shuts down all instances for now), there isn't a generic end point supplied with cf-mysql-release.

Instead, the software which includes cf-mysql-release as part of their deployment includes the backup scripts called by bbr, as they perform both the steps to quiesce the app as well as perform the backup (or restore).

For the moment, there isn't a high priority to back up the deployment which is used by the service-broker.

-- Marco Nicosia Product Manager Pivotal Software, Inc.

gberche-orange commented 6 years ago

Thanks @menicosia. I understand that BBR API is not yet exposed to CF application developer as part of CC API, and not exposed to service brokers through OSB. As such, asking application developers to trigger consistent mysql-release backups would require apps to broker specific interactions (e.g. through a mysql-release dashboard or a custom REST API endpoint).

As a workaround until such on-demand back up support gets standardized into OSB (https://github.com/openservicebrokerapi/servicebroker/issues/114) and exposed into CC API, I feel service operators have to backup user subscriptions without getting user triggered data consistency.

As CF and bosh community suggest standardisation of backup/restore using BBR contract, we feel that the consistent backup logic documented into https://github.com/cloudfoundry/cf-mysql-release/blob/develop/docs/backup-restore.md should be rather automated into the cf-mysql-release bbr contract implementation, rather than being duplicated in external backups product like https://github.com/starkandwayne/shield/pull/374

Would a PR adding BBR support for backup/restore the service broker data, along with all of the provisionned databases data be considered ?