search

cloudfoundry / cf-mysql-release

Cloud Foundry MySQL Release
Apache License 2.0
58 stars 106 forks source link

Standard Configuration Change required at my.cnf.erb #225

Open rbrihaspathi opened 5 years ago

rbrihaspathi commented 5 years ago

Thank you for submitting an issue.

Feature Request Info

Problem you are trying to solve

Help us understand the problem you are facing. Please provide as much context as possible. pc.recovery value should be set to TRUE instead of FALSE. (in my.cnf.erb file, for wsrep_provider_options parameter)

Proposed solution/feature

What is the proposed solution and why do you think it is the best approach to the problem above. Value should be TRUE instead of False. When it is TRUE, Galera will save the database view state to file on disk when it shuts down and which will be easy to recover the db from the state where it was.

Would you want to open an PR for this feature?

Bug Report Info

Currently:

What is the current broken behavior? Node recovery will not happen automatically.

Expected:

What the correct behavior should be? Node should be recovered automatically.

Steps to Reproduce:

Please provide as much detail as possible.

Deployment Context:

Please provide relevant details about your deployment. That might include:

Reference:

Attach screenshot(s) or logs if relevant

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/166030030

The labels on this github issue will be updated when the story is started.

bgandon commented 5 years ago

Hi @menicosia, what do you guys thing about adopting this improvement, setting pc.recovery to true in order to improve nodes restarts?

menicosia commented 5 years ago

Hi @rbrihaspathi and @bgandon,

We enabled pc.recovery=TRUE way back in v21 [#90573188], but then disabled it again in v36.11. Check out the reasoning in this story: #153572034 and let us know what you think.

If you agree that unfortunately, we should leave it as it is, then please close this issue. If there's a specific issue that you are seeing when operating these (we very rarely see the need for pc.recovery=TRUE) please let us know how the default is affecting you. That may influence our reasoning per above story, in addition to any experiences of our own.

Thanks for raising this issue!