Open kanngiesser opened 2 weeks ago
Hi @kanngiesser
Thank you for reporting this.
The decider is doing the correct behaviour as it is conforming to the OSBAPI spec for the case when maintenance info is published.
You are correct that the right behaviour is for the client update
command to send the correct maintenance info version.
Unfortunately, the team does not have the bandwidth to work on this request at the moment and we can't promise when or if we would be able to pick this up. However, we would happily review a PR if you are able to do that.
Thank you, Felisia
Description
The
client update
command fails for service instances which were provisioned bycsb client provision
Expected Behavior
It should be possible to run
csb client update
for service instances which were provisioned withcsb client provision
. Service updates should allow to change user-provided parameters and to change the service plan.Actual Behavior
The
client update
command fails with error messageerror deciding update path: passed maintenance_info does not match the catalog maintenance_info
.Possible Fix
The
client update
command should send a value forprevious_values.maintenance_info.version
andmaintenance_info.version
when sending the update request. Both values must match. With the current implementation, bothprevious_values
andmaintenance_info
are left empty when sending the request.Alternatively,
brokerapi/broker/decider/decider.go
should be updated to match the use-case for the client update command instead of throwing ErrMaintenanceInfoConflictSteps to Reproduce
csb client provision --serviceid "${SERVICEID}" --planid "${PLANID}" --instanceid "${INSTANCEID}"
csb client update --serviceid "${SERVICEID}" --planid "${PLANID}" --instanceid "${INSTANCEID}" --instanceid "1" --params '{}'
Context
Failed to test service updates (after import) locally during Brokerpak development
Your Environment
Version used: v2.1.2 Operating System and version (desktop): Ubuntu 22.04.4 LTS (Running from Docker image mcr.microsoft.com/devcontainers/base:jammy) Link to your project (if public): -- Platform (Azure/AWS/GCP): Local Testing Applicable Services: Running with mariadb:11.4.2-noble backend (Docker)