search

cloudfour / eslint-config

MIT License
4 stars 1 forks source link

Drop support for node 16 #572

Closed calebeby closed 1 year ago

calebeby commented 1 year ago

Node 16 is EOL as of last week. Hoping this might fix https://github.com/cloudfour/eslint-config/pull/566#issuecomment-1726458063 since it looks like renovate is using npm@10, and npm@10 only supports node 18+.

Not sure if this will fix it though since renovate's update process doesn't depend on GH actions and might not read the engines field in package.json

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: c2fe380cf64b41637e7a2f04718c1703157bafe7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------ | ----- | | @cloudfour/eslint-plugin | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

spaceninja commented 1 year ago

Does the version of Node this repo uses affect consumers of our eslint library?

calebeby commented 1 year ago

Yes. Consumers of this eslint library will get install warnings if they try to update this dependency without also updating node to a supported version. (once we publish a new version of this library).

They can continue to use the older version of the eslint config if they are unable to update node right away.