cloudmatrix / esky

an auto-update framework for frozen python apps
BSD 3-Clause "New" or "Revised" License
363 stars 74 forks source link

make data_files setup option work like cx freeze #108

Closed timeyyy closed 6 years ago

timeyyy commented 8 years ago

basically i think its cleaner to do (folder, folder) (file, file)

than (folder, glob(r'.\folder\*.*') ('', [file])

it is also consistent with py2exe and cxfreeze and requires users to not have to modify there setup files.

are we cool this implement this?

rfk commented 8 years ago

data_files is a standard distutils option [1] so I think we should remain consistent with whatever its base semantics are; adding additional conveniences sounds fine though. Do py2exe and cxfreeze use it in a non-distutils-standard way?

[1] https://docs.python.org/2/distutils/setupscript.html#installing-additional-files

timeyyy commented 8 years ago

actually it's only cx freeze that implements it the way i proposed. its a bit different than standard distutils. the concept of cxfreeze is a sequence of (to, from)

the concept of distutils is (directory, [files])

cx freeze uses the option name include_files, mm i'm guessing passing the vales through like this options={"bdist_esky": {"freezer_options": { "include_files": INCLUDES}}} would work,

i guess the solution might be to add more documentation in the tutorial and wiki prompting the freezer_options feature

rfk commented 8 years ago

We could also support include_files in addition to data_files, changing the get_data_files method in esky/bdist_esky/init.py so that it looks for files in both places.

timeyyy commented 8 years ago

sounds good!

rfk commented 6 years ago

Thanks for reaching out. Unfortunately this project is no longer actively maintained, so I'm going to move it into archive mode:

https://rfk.id.au/blog/entry/archiving-open-source-projects/