Fix for two bytes issues

cloudmatrix / esky

an auto-update framework for frozen python apps

BSD 3-Clause "New" or "Revised" License

363 stars 74 forks source link

Fix for two bytes issues #115

Closed JPFrancoia closed 8 years ago

JPFrancoia commented 8 years ago

Why is travis failing ?

The command "sudo apt-get install cx-freeze" failed and exited with 100 during .

Because of cx-freeze, or because of my code ?

timeyyy commented 8 years ago

nah, they are updating there servers.

JPFrancoia commented 8 years ago

Ok. Will the tests be re-ran automatically ?

timeyyy commented 8 years ago

i don't think so, but they are the same test you run locally so you can test and post the results

JPFrancoia commented 8 years ago

So here are the results of the tests: out.txt

Out of 40, 39 passed. The only remaining is test_esky_cxfreeze_needsroot, but as discussed in #113, it only doesn't work for me.

If I run it with sudo:

out2.txt

It passes.

timeyyy commented 8 years ago

@JPFrancoia this patch isn't finish is that correct? Do you know how i can move the correction from djipey to a new pull request as they target another issue...