fix a bug on *nix system about permission copy

cloudmatrix / esky

an auto-update framework for frozen python apps

BSD 3-Clause "New" or "Revised" License

363 stars 74 forks source link

fix a bug on *nix system about permission copy #146

Closed djoproject closed 6 years ago

djoproject commented 8 years ago

A previous commit already fixed this bug for python3 but not for python2. Here is a generic update working with both versions.

This bug breaks esky with py2app on OSX and probably on every *nix system when symbolic link are used in the packaging.
During an update process on OSX, it tries to apply the owner+group of /usr/bin/python (owner:root, group:wheel) to ./Content/MacOS/python(owner:CURRENT_USER, group:staff). But the last one is just a symbolic link to the python binary and shouldn't have root rights.

I also updated the code to be compliant with PEP8.

kennedyshead commented 8 years ago

+1 for merge!

timeyyy commented 8 years ago

Kenny, did you review the patch?

djoproject commented 7 years ago

I add a new commit to fix some bugs in the patch system:

the zip file header was used in hash computation, sometimes two equal zips had different header. (I don't have more information about this, I didn't explore the zip documentation)
some zip files contain directory entries, and the function that copy zip files didn't manage that. The result was two different zip (and so two different hash) with the same content after extraction.
on patch application, the original application is completely copied before to apply the patch, the content of the files targetted by symlinks was copied too. Now just the symlinks are copied with symlink right preservation.

rfk commented 6 years ago

Thanks for contributing this. Unfortunately this project is no longer actively maintained, so I'm going to move it into archive mode:

https://rfk.id.au/blog/entry/archiving-open-source-projects/