cloudmatrix / esky

an auto-update framework for frozen python apps
BSD 3-Clause "New" or "Revised" License
363 stars 74 forks source link

add support for cx_Freeze 5 #150

Closed mortbauer closed 6 years ago

mortbauer commented 7 years ago

To support cx_Freeze 5 I added a new module f_cxfreeze5 which is pulled in instead of f_cxfreeze if the cx_Freeze version starts with 5. This new module is mostly a copy of f_cxfreeze.

Only tested it on Windows7 so far, and it works great for me. Since all the other functionality should be completely as before this should work.

I made the changes on the 3k branch, since the master branch didn't work for me under python 3.6.

timeyyy commented 7 years ago

Looks pretty tight man, as the project is unmaintained we could link to your fork if you would like?

mortbauer commented 7 years ago

Yes sure, if it helps.

The thing is that at the moment cx_Freeze 5 seems to be the best option for python3 supporting multipackage executables (aren't working currently in pyinstaller), so that's why I wanted to make esky work with cx_Freeze 5 which wasn't to difficult after understanding the process, which seems to be completely undocumented.

Another thing I'm not sure about is the status of python3 in esky anyways, the master branch should be able to work with 2to3 I thought, but it didn't thats why I applied my changes to the 3k branch.

timeyyy commented 7 years ago

The main reason I created the 3k branch was because I have never used python two, the bigger reason was that the tests cannot be run for python3 on the python2 branch.

I dropped maintaining this because I couldn't get cxfreeze to package on linux.

rfk commented 6 years ago

Thanks for contributing this. Unfortunately this project is no longer actively maintained, so I'm going to move it into archive mode:

https://rfk.id.au/blog/entry/archiving-open-source-projects/