search

cloudmesh / cloudmesh-cmsd

Other
0 stars 2 forks source link

docker image retrieval on windows #2

Open amirjankar opened 4 years ago

amirjankar commented 4 years ago

https://github.com/cloudmesh/cloudmesh-cmsd/blob/master/cloudmesh_cmsd/cmsd/command/cmsd.py#L424

solution:

docker images "cloudmesh-cms:latest"
laszewsk commented 4 years ago

good find! Niranda can you verify

amirjankar commented 4 years ago

https://github.com/cloudmesh/cloudmesh-cmsd/blob/master/cloudmesh_cmsd/cmsd/command/cmsd.py#L238-L245

# Windows/cross-platform code that works
docker run -d -it \
    --mount type=bind,src={cloudmesh_home_dir},dst=/root/.cloudmesh \
    --mount type=bind,src=~/cm,dst=/cm \
    --mount type=bind,src=~/.ssh,dst=/root/.ssh \
    --net host \
    --name {CMS_CONTAINER_NAME} \
    {CMS_IMAGE_NAME}

Also, could I add an -e tag that adds the cm directory as a volume so that we can use it for testing? New code above

laszewsk commented 4 years ago

Niranda we need to verify the difference between volume management. As I recall I use -v he suggests to add a -e tag, I do not think I ever used that.

Also it looks like that here the --mount is used instead of -v

Can we look into the difference

laszewsk commented 4 years ago

anish, please file separate issues if you can so refile this and add my comment