cloudoperators / juno

Monorepo for the Juno modular frontend framework, apps, design system and component library
http://cloudoperators.github.io/juno/
Apache License 2.0
4 stars 0 forks source link

feat(heureka): adds pagination for component instances on a service details panel #577

Closed hodanoori closed 3 weeks ago

hodanoori commented 1 month ago

Summary

This PR adds pagination to the list of component instances for a selected service on the service details page.

Changes Made

Related Issues

Testing Instructions

  1. npm i
  2. npm run TASK

Checklist

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 9a7fc60d85d6dafcfb6ef00ac5acf024e8671d54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ----------------------------------- | ----- | | @cloudoperators/juno-app-heureka | Minor | | @cloudoperators/juno-app-greenhouse | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

hodanoori commented 1 month ago
github-actions[bot] commented 1 month ago

PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-11-08 14:46 UTC

hodanoori commented 3 weeks ago
  1. Maybe you do not need useMemo in places, but I am not sure please let me know what do you think
  2. Would be nice to write some tests if it necessary for the components that you introduce.

Thanks for your review. I removed useMemos and added a test for the newly added component. Please have a look here again.

hodanoori commented 3 weeks ago

lgtm but please take my suggestions into account for the future.

Good Idea, I'll create a new PR for it.

hodanoori commented 3 weeks ago

I have a few questions regarding mocking, especially if start mocking our own behaviour, it means that the component use this behaviour wrong, kinda a good sign to rethink the state lifecycle.

I do not get your point, Those mocks are belonging to other components which has their own tests.

hodanoori commented 3 weeks ago

I have a few questions regarding mocking, especially if start mocking our own behaviour, it means that the component use this behaviour wrong, kinda a good sign to rethink the state lifecycle.

I separated the pagination component and added a test for that component. Please have a look there again.