Closed hodanoori closed 3 weeks ago
Latest commit: 9a7fc60d85d6dafcfb6ef00ac5acf024e8671d54
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-11-08 14:46 UTC
- Maybe you do not need useMemo in places, but I am not sure please let me know what do you think
- Would be nice to write some tests if it necessary for the components that you introduce.
Thanks for your review. I removed useMemos and added a test for the newly added component. Please have a look here again.
lgtm but please take my suggestions into account for the future.
Good Idea, I'll create a new PR for it.
I have a few questions regarding mocking, especially if start mocking our own behaviour, it means that the component use this behaviour wrong, kinda a good sign to rethink the state lifecycle.
I do not get your point, Those mocks are belonging to other components which has their own tests.
I have a few questions regarding mocking, especially if start mocking our own behaviour, it means that the component use this behaviour wrong, kinda a good sign to rethink the state lifecycle.
I separated the pagination component and added a test for that component. Please have a look there again.
Summary
This PR adds pagination to the list of component instances for a selected service on the service details page.
Changes Made
first: 8
parameter to display a maximum of 8 component instances per page, minimizing the need for scrolling within the panel.Related Issues
Testing Instructions
npm i
npm run TASK
Checklist