cloudoperators / juno

Monorepo for the Juno modular frontend framework, apps, design system and component library

http://cloudoperators.github.io/juno/

Apache License 2.0

4 stars 0 forks source link

chore(ui): migrate Grid, GridColumn and GridRow components to Typescript #595

Closed guoda-puidokaite closed 3 weeks ago

guoda-puidokaite commented 3 weeks ago

Summary

Migrated the Grid, GridColumn and GridRow components to TypeScript, enhancing code quality, maintainability, and scalability.
Utilised static typing to minimize runtime errors and improve the development experience.
Removed deprecated Grid, GridColumn and GridRow .js components
Refactored the component for cleaner, more maintainable code.

Changes Made

TypeScript Migration:

Converted Grid, GridColumn and GridRow component files to TypeScript.
Added comprehensive type annotations.

Cleanup:

Removed deprecated code. It wasn't needed for any .js components.

Refactoring:

Made necessary adjustments to address TypeScript-detected issues.
Further refactored for cleaner and more understandable code.

Testing:

Added edge case tests: https://github.com/cloudoperators/juno/pull/595/commits/28dc6becae5fdd702d22b7ded014648d9bcfda7d
Organised tests by what they check for better readability and maintenance.
Verified component behaviour using Storybook.
Updated tests to use vitest.

Documentation:

Updated Storybook documentation.

Release:

Generated a changeset file.

Related Issues

https://github.com/cloudoperators/juno/issues/229

Testing Instructions

Check deployedStorybook

Checklist

[x] I have performed a self-review of my code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[x] I have made corresponding changes to the documentation (if applicable).
[x] My changes generate no new warnings or errors.

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 90e50ebb11dfb47ce2584d739f1da06b3aa820fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ---------------------------------- | ----- | | @cloudoperators/juno-ui-components | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 weeks ago

PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-11-07 16:10 UTC